Skip to content

Add force unmount after timeout option #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add force unmount after timeout option #1710

wants to merge 1 commit into from
+48 −25

Conversation

DavidXU12345
Copy link
Contributor

Is this a bug fix or adding new feature?
Adding new feature.

What is this PR about? / Why do we need it?
The force-unmount-after-timeout feature addresses issues when NodeUnpublishVolume gets called infinite times and hangs indefinitely due to broken NFS connections. Kubelet will keep trying RPC NodeUnpublishVolume and ultimately cause OOMKilled for the pod.

When enabled, if a normal unmount operation exceeds the configured timeout, the driver will forcibly unmount the volume to prevent indefinite hanging and allow the operation to complete. By default, the timeout limit is 30 seconds while user can also specify the timeout duration.

What testing is done?

  • E2E test with feature disabled
  • Confirmed force unmount behavior with simulated broken NFS connections

@DavidXU12345
Add force unmount after timeout option
a88f165 
For NodeUnpublishVolume call, it is possible to get stuck due to broken
NFS connection. A force unmount after timeout option is added to avoid
this.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidXU12345
Once this PR has been reviewed and has the lgtm label, please assign mskanth972 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @DavidXU12345. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankova22 dankova22 Awaiting requested review from dankova22

@nckturner nckturner Awaiting requested review from nckturner

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidXU12345 @k8s-ci-robot